refactor(utils): extract useReduxConnection for less repetition#45
Closed
PrettyCoffee wants to merge 2 commits into
Closed
refactor(utils): extract useReduxConnection for less repetition#45PrettyCoffee wants to merge 2 commits into
PrettyCoffee wants to merge 2 commits into
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 37197c8:
|
dai-shi
reviewed
Mar 19, 2023
| useEffect(() => { | ||
| didMount.current = true; | ||
| }, []); | ||
| return didMount.current; |
Member
There was a problem hiding this comment.
I don't like useDidMount as a React practice. Specifically, this is violating the React rule: We shouldn't read a ref value in render.
Maybe, it was implemented so previously. This reveals it then.
Contributor
Author
There was a problem hiding this comment.
I will check if I can work around it, so I don't have to use useDidMount. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chunk of this PR: #32
This will extract the repeated logic of
useAtomDevtoolsanduseAtomsDevtoolsregarding the initial connection to the redux extension into a shared custom hook. It will be helpful to implement consistent behavior for both hooks. 🙂(for example when reduxjs/redux-devtools#1370 is fixed or #32 is implemented as temporary solution or if there is any other solution for the duplicated connection problem)
This is only a refactoring, it should not introduce any behavioral changes.