[refactor!]: changed resultObservable deep -> ref globally#79
[refactor!]: changed resultObservable deep -> ref globally#79
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe default value for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 39 minutes and 56 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/base-query.ts`:
- Around line 135-137: The change to default resultObservable to 'ref' breaks
existing deep-mutation behavior; revert the defaulting logic so resultObservable
preserves previous behavior (use 'deep' unless explicitly overridden) by
adjusting the assignment that sets resultObservable (currently using
config.resultObservable ?? qf?.resultObservable ?? 'ref') to prefer 'deep' as
the fallback (or preserve qf/config if present) so nested in-place mutations
continue to trigger reactions; update the initialization in the
function/constructor where resultObservable is set (look for the
resultObservable, config, and qf symbols) to return 'deep' when no explicit
option is provided.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 83219d60-a55a-4412-af27-78272036a647
📒 Files selected for processing (10)
.changeset/friendly-mails-cheat.mddocs/api/Mutation.mddocs/api/Query.mdsrc/base-query.tssrc/infinite-query.test.tssrc/mutation.test.tssrc/mutation.tssrc/mutation.types.tssrc/query.test.tssrc/query.types.ts
Summary by CodeRabbit
Breaking Changes
resultObservable: 'deep'.Documentation