Skip to content

Remove duplicate cells on document change #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jordanhboxer wants to merge 1 commit into from
Closed

Remove duplicate cells on document change #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/jupyter-server-ydoc/jupyter_server_ydoc/rooms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,10 @@ def _on_document_change(self, target: str, event: Any) -> None:
document. This tasks are debounced (60 seconds by default) so we
need to cancel previous tasks before creating a new one.
"""
remove_duplicate_cells = getattr(self._document, "remove_duplicate_cells", None)
if target == "cells" and remove_duplicate_cells is not None:
asyncio.get_running_loop().call_soon(remove_duplicate_cells)

Comment on lines +250 to +253
Copy link
Copy Markdown
Collaborator

@davidbrochart davidbrochart Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I still see that as an abstraction leak.

Copy link
Copy Markdown
Contributor Author

@jordanhboxer jordanhboxer Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point. adding an observe cells callback to handle in jupyter-server/jupyter_ydoc#397

# Collect autosave values from all clients
autosave_states = [
state.get("autosave", True)
Expand Down
Loading