Change syntax highlighter to Prism#39
Open
obskyr wants to merge 2 commits into
Open
Conversation
expatjedi
approved these changes
Jan 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the syntax highlighting used -
highlight.js- was... less than satisfactory, and really messed with the otherwise brilliant and stylish feel of the theme. So I changed it to Prism (which is of course open-source and under a permissive license - MIT, to be exact), fixed up the style a bit extra to fit even better with Crisp and work well on mobile, and I gotta say: the results are wonderful. Here, take a look at some examples - just make sure to click them to get the full-res experience.Example 1, current style (
highlight.js):Example 1, new style (Prism):
Example 2, current style (
highlight.js):Example 2, new style (Prism):
Way better, right? I think so, at least. With this PR, Crisp comes with documented support for HTML, CSS, JavaScript, Handlebars, C, C++, C#, C-likes, Python and Ruby, and is easily extensible by any user by following the instructions in the readme. It affects both triple-tick code blocks and inline ones with a unified style.
You can check out a live blog post with the changes implemented here; just scroll down a bit.