Skip to content

Fix #23110: GPU memory leak in torch tree utilities (closure captures tensor containers) #23206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
utsab345 wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

Fix #23110: GPU memory leak in torch tree utilities (closure captures tensor containers) #23206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion keras/src/tree/optree_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,12 @@ def is_nested(structure):

def traverse(func, structure, top_down=True):
# From https://github.com/google/jax/pull/19695
structure_id = id(structure)

def traverse_children():
children, treedef = optree.tree_flatten(
structure,
is_leaf=lambda x: x is not structure,
is_leaf=lambda x: id(x) != structure_id,
none_is_leaf=True,
namespace="keras",
)
Expand Down
7 changes: 5 additions & 2 deletions keras/src/tree/torchtree_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@ def func(x):
)
return None

structure_id = id(structure)

def traverse_children():
children, treedef = torch_tree.tree_flatten(
structure,
is_leaf=lambda x: x is not structure,
is_leaf=lambda x: id(x) != structure_id,
)
if treedef.num_nodes == 1 and treedef.num_leaves == 1:
return structure
Expand All @@ -62,7 +64,7 @@ def traverse(func, structure, top_down=True):
def traverse_children():
children, treedef = torch_tree.tree_flatten(
structure,
is_leaf=lambda x: x is not structure,
is_leaf=lambda x: id(x) != structure_id,
)
if treedef.num_nodes == 1 and treedef.num_leaves == 1:
return structure
Expand All @@ -73,6 +75,7 @@ def traverse_children():
)

structure = _dict_to_ordered_dict(structure)
structure_id = id(structure)
if top_down:
ret = func(structure)
if ret is None:
Expand Down