Skip to content

change(web): remove unused transition-edit field 🔪#16071

Open
jahorton wants to merge 1 commit into
change/web/adjust-tokenization-corrector-specfrom
change/web/remove-unused-transition-edit-field
Open

change(web): remove unused transition-edit field 🔪#16071
jahorton wants to merge 1 commit into
change/web/adjust-tokenization-corrector-specfrom
change/web/remove-unused-transition-edit-field

Conversation

@jahorton

@jahorton jahorton commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

The transitionEdit field of ContextTokenization existed to indicate how it was reached via transition - back when there was only one transition path under consideration. It was not actually utilized in any form from this location.

Additionally, with epic/boundary-correction, each ContextTokenization instance may be reached by multiple different paths and may even "cluster" these paths. There won't be a "single" path, so the field makes even less sense to maintain now than it did before. It's time to axe it.

Build-bot: skip build:web
Test-bot: skip

@keymanapp-test-bot

keymanapp-test-bot Bot commented Jun 4, 2026

Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")

@github-actions github-actions Bot added web/ web/predictive-text/ change Minor change in functionality, but not new labels Jun 4, 2026
@keymanapp-test-bot keymanapp-test-bot Bot changed the title change(web): remove unused transition-edit field change(web): remove unused transition-edit field 🔪 Jun 4, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S30 milestone Jun 4, 2026
@keyman-server keyman-server modified the milestones: A19S30, A19S31 Jun 8, 2026
@jahorton jahorton force-pushed the feat/web/prep-tokenization-search branch from 5631d8f to 702efa3 Compare June 12, 2026 15:43
@jahorton jahorton force-pushed the change/web/remove-unused-transition-edit-field branch from 3948c1d to 82b9f18 Compare June 12, 2026 15:44
@jahorton jahorton force-pushed the feat/web/prep-tokenization-search branch from 702efa3 to bc32ac3 Compare June 12, 2026 17:07
@jahorton jahorton force-pushed the change/web/remove-unused-transition-edit-field branch from 82b9f18 to 0b97139 Compare June 12, 2026 17:07
Build-bot: skip build:web
Test-bot: skip
@jahorton jahorton force-pushed the change/web/remove-unused-transition-edit-field branch from 0b97139 to c2816da Compare June 12, 2026 17:12
@jahorton jahorton changed the base branch from feat/web/prep-tokenization-search to change/web/adjust-tokenization-corrector-spec June 12, 2026 17:12
@jahorton jahorton requested a review from ermshiperete June 12, 2026 17:36
@jahorton jahorton marked this pull request as ready for review June 12, 2026 17:36
@keyman-server keyman-server modified the milestones: A19S31, A19S32 Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

3 participants