Skip to content

feat(developer): reviewRules: return object instead of string[] 😎 #16073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SabineSIL wants to merge 2 commits into
base: feat/developer/kmc-convert
Choose a base branch
from
Draft

feat(developer): reviewRules: return object instead of string[] 😎 #16073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70bbf61
feat(developer): reviewRules: return object instead of string[] messa…
SabineSIL Jun 6, 2026
0a5dbe3
feat(developer): reviewRules: return object instead of string[]
SabineSIL Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion developer/src/common/web/utils/src/xml-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Abstraction for XML reading and writing
*/

import { XMLParser, XMLBuilder, XMLMetaData, X2jOptions, XmlBuilderOptions, JPathOrMatcher } from 'fast-xml-parser';
import { XMLParser, XMLBuilder, XMLMetaData, X2jOptions, XmlBuilderOptions,JPathOrMatcher } from 'fast-xml-parser';
import { SymbolUtils } from "./symbol-utils.js";

/** Symbol giving the start offset, in chars, of the node */
Expand Down
17 changes: 3 additions & 14 deletions developer/src/kmc-convert/src/converter-messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
import { CompilerErrorNamespace, CompilerErrorSeverity, CompilerMessageSpec as m, CompilerMessageDef as def } from '@keymanapp/developer-utils';

const Namespace = CompilerErrorNamespace.Converter;
//const SevInfo = CompilerErrorSeverity.Info | Namespace;
const SevHint = CompilerErrorSeverity.Hint | Namespace;
const SevWarn = CompilerErrorSeverity.Warn | Namespace;
// const SevInfo = CompilerErrorSeverity.Info | Namespace;
// const SevHint = CompilerErrorSeverity.Hint | Namespace;
// const SevWarn = CompilerErrorSeverity.Warn | Namespace;
const SevError = CompilerErrorSeverity.Error | Namespace;
// const SevFatal = CompilerErrorSeverity.Fatal | Namespace;

Expand Down Expand Up @@ -77,15 +77,4 @@ export class ConverterMessages {
`Input data could not be parsed.`
);

static WARN_EmptyOutput = SevWarn | 0x000D;
static Warn_EmptyOutput =(o: { keymapIndex: string, key: string, KeyName: string; }) => m(
this.WARN_EmptyOutput,
`Key has empty output (possibly caused by use of html entity) at keyMap index ${def(o.keymapIndex)} on Keycode ${def(o.key)} (${def(o.KeyName)})`
);
static HINT_EmptyOutput = SevHint | 0x000E;
static Hint_EmptyOutput =(o: { keymapIndex: string, key: string, KeyName: string; }) => m(
this.HINT_EmptyOutput,
`Key has empty output at keyMap index ${def(o.keymapIndex)} on Keycode ${def(o.key)} (${def(o.KeyName)}) possibly caused by use of html entity `
);

}
Loading
Loading