Skip to content

fix(developer): map shift key nextlayer property when importing OSK #16110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcdurdin wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −0
Open

fix(developer): map shift key nextlayer property when importing OSK #16110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions developer/src/kmconvert/Keyman.Developer.System.VisualKeyboardToTouchLayoutConverter.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,23 @@ function TVisualKeyboardToTouchLayoutConverter.SetupModifierKeysForImportedLayou

for l in p.Layers do
begin
// Find the Shift key and assign the next layer
k := l.FindKeyById('K_SHIFT');
if Assigned(k) then
begin
if l.id = 'default' then
begin
k.NextLayer := 'shift';
end
else
begin
// All layers other than default will return to default layer
// when shift is pressed, because we do not currently map
// shift+other mod layers with use of the Shift key in the import
k.NextLayer := 'default';
end;
end;

// Find the Ctrl key for the layer
k := l.FindKeyById('K_LCONTROL');
if not Assigned(k) then
Expand Down