Skip to content

fix(web): do not auto-select model-matching keep suggestions 🚂#16123

Open
jahorton wants to merge 1 commit into
epic/autocorrectfrom
fix/web/block-keep-autoaccept
Open

fix(web): do not auto-select model-matching keep suggestions 🚂#16123
jahorton wants to merge 1 commit into
epic/autocorrectfrom
fix/web/block-keep-autoaccept

Conversation

@jahorton

@jahorton jahorton commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes: #12312

Do not auto-select model-matching keep suggestions. Do, however, prevent auto-selection of any other suggestion when a model-matching 'keep' is available.

Build-bot: skip build:web build:android build:ios

User Testing

TEST_UNSELECTED_KEEP: Using Keyman for Android, verify that typing a complete, correctly-spelled word does not result in a selected suggestion matching the word.

  1. Use sil_euro_latin and the MTNT model.
  2. Clear any pre-existing context.
  3. Type "search".
  4. Verify that the left-most option displays "search" and that it is not highlighted (and thus, not a candidate for automatic application).

TEST_SELECTED_NEAR_MATCH: Using Keyman for Android, verify that typing a complete, correctly-spelled word does not result in a selected suggestion matching the word.

  1. Use sil_euro_latin and the MTNT model.
  2. Clear any pre-existing context.
  3. Type "searchi".
  4. Verify that the second-left-most option displays "searching" and that it is highlighted (and thus, a candidate for automatic application).

@jahorton
fix(web): do not auto-select model-matching keep suggestions
b029b19 
Fixes: #12312

Do, however, prevent auto-selection of any other suggestion when a model-matching 'keep' is available.

Build-bot: skip build:web build:android build:ios
@jahorton jahorton requested a review from ermshiperete June 22, 2026 19:06
@github-project-automation github-project-automation Bot moved this to Todo in Keyman Jun 22, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added has-user-test user-test-required User tests have not been completed labels Jun 22, 2026
@keymanapp-test-bot

keymanapp-test-bot Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

User Test Results

Test specification and instructions

  • ⬜ TEST_UNSELECTED_KEEP (OPEN)
  • ⬜ TEST_SELECTED_NEAR_MATCH (OPEN)
Results Template 
# Test Results

* **TEST_UNSELECTED_KEEP (OPEN):** notes
* **TEST_SELECTED_NEAR_MATCH (OPEN):** notes

Test Artifacts

  • Android
    • Keyman for Android apk - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Android apk - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Android apk (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • KeyboardHarness apk - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for Android apk (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • KMSample1 apk - build : all tests passed (no artifacts on BuildLevel "build")
    • KMSample2 apk - build : all tests passed (no artifacts on BuildLevel "build")
  • iOS
    • Keyman for iOS (simulator image) - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for iOS (simulator image) - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for iOS (simulator image) (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for iOS (simulator image) (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot Bot changed the title fix(web): do not auto-select model-matching keep suggestions fix(web): do not auto-select model-matching keep suggestions 🚂 Jun 22, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S32 milestone Jun 22, 2026
@Meng-Heng Meng-Heng self-assigned this Jun 23, 2026
@Meng-Heng

Meng-Heng commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Hello, @jahorton. There might a failed build? Could you help check why the Keyman keyboard does not load when I launch keyman-19.0.241.apk?

Errors are the following:

  • Error in keyboard(s) for language(s)
  • No access to server (something along this line)

It happened in Android Emulator and Android physical device.

@jahorton

jahorton commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Hello, @jahorton. There might a failed build? Could you help check why the Keyman keyboard does not load when I launch keyman-19.0.241.apk?

Errors are the following:

* Error in _keyboard(s)_ for _language(s)_

* No access to server (something along this line)

It happened in Android Emulator and Android physical device.

... this might be something Marc / Eberhard mentioned about Web's current alpha. Disregard for now; we'll test when they get it fixed.

ermshiperete
ermshiperete approved these changes Jun 23, 2026
View reviewed changes

@ermshiperete ermshiperete left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the unit tests are fixed)

@Meng-Heng

Meng-Heng commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Noted, thank you for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ermshiperete ermshiperete ermshiperete approved these changes

Assignees

@Meng-Heng Meng-Heng

Labels

epic-autocorrect fix has-user-test user-test-required User tests have not been completed web/predictive-text/ web/

Projects

Keyman
Status: Todo

Milestone

A19S32

Development

Successfully merging this pull request may close these issues.

3 participants

@jahorton @Meng-Heng @ermshiperete