Skip to content

fix(web): do not auto-select model-matching keep suggestions 🚂 #16123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jahorton wants to merge 1 commit into
base: epic/autocorrect
Choose a base branch
from
+6 −4
Open

fix(web): do not auto-select model-matching keep suggestions 🚂 #16123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions web/src/engine/predictive-text/worker-thread/src/main/predict-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,9 +965,11 @@ export function predictionAutoSelect(suggestionDistribution: CorrectionPredictio

const keepOption = suggestionDistribution[0].prediction.sample as Outcome<Keep>;
if(keepOption.tag == 'keep' && keepOption.matchesModel) {
// Auto-select it for auto-acceptance; we don't correct away from perfectly-valid
// lexical entries, even if they are comparatively low-frequency.
keepOption.autoAccept = true;
// Do not auto-select 'keep' suggestions'; there's no need to apply them.
//
// Do, however, block auto-selection of any other suggestions if we would
// have auto-selected the 'keep'; even if it is comparatively unlikely /
// low-frequency, we 'keep' the current context.
return;
} else if(suggestionDistribution.length == 1) {
return;
Expand Down
2 changes: 1 addition & 1 deletion web/src/engine/src/interfaces/prediction/predictionContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ export class PredictionContext extends EventEmitter<PredictionContextEventMap> {
this._revertSuggestion = s as Reversion;
}

if (this.langProcessor.mayAutoCorrect && s.autoAccept && !this.selected) {
if (this.langProcessor.mayAutoCorrect && s.autoAccept && !this.selected && s.tag != 'keep') {
this.selected = s;
}
}
Expand Down
Loading