fix(developer): consolidate user options in TypeScript code#16134
Open
mcdurdin wants to merge 1 commit into
Open
fix(developer): consolidate user options in TypeScript code#16134mcdurdin wants to merge 1 commit into
mcdurdin wants to merge 1 commit into
Conversation
* Remove Server's 'config.json' redundant user options handling * Refactor options.ts in Server and kmc to share common cross-platform code * Move option defaults into common code and sync with .pas defaults * Rename config.ts to standardPaths.ts to better represent the remaining purpose of the module. Fixes: #13458
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions
Results Template |
ermshiperete
approved these changes
Jun 24, 2026
|
|
||
| /** | ||
| * The set of standard user options for Keyman Developer. Corresponds to | ||
| * TKeymanDeveloperOptions in the Keyman Developer TIKE source. |
Contributor
There was a problem hiding this comment.
Wondering if it would be better to state the filename?
Suggested change
| * TKeymanDeveloperOptions in the Keyman Developer TIKE source. | |
| * TKeymanDeveloperOptions in `developer/src/tike/main/KeymanDeveloperOptions.pas` |
| export type KeymanDeveloperOption = keyof KeymanDeveloperOptions; | ||
|
|
||
| const DEFAULT_OPTIONS: KeymanDeveloperOptions = { | ||
| // Corresponds to KeymanDeveloperOptions.pas, TKeymanDeveloperOptions.Read |
Contributor
There was a problem hiding this comment.
A bit clearer might be:
Suggested change
| // Corresponds to KeymanDeveloperOptions.pas, TKeymanDeveloperOptions.Read | |
| // Corresponds to TKeymanDeveloperOptions.Read in KeymanDeveloperOptions.pas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13458
User Testing