Feat/new train request endpoint#555
Merged
kitsudaiki merged 4 commits intodevelopfrom May 17, 2025
Merged
Conversation
A new switch for the cluster was added to change the mode between direct and task mode again. The new implementation is also more robust than the old one. Signed-off-by: Tobias Anker <tobias.anker@kitsunemimi.moe>
Added new train and request api endpoint to directly trigger these actions for single-inputs without an async task. Also tested the request in the sdk-api-test to check the train results. Signed-off-by: Tobias Anker <tobias.anker@kitsunemimi.moe>
Cluster-handle are not not locked per task, but per iteration within the task. This way, tasks and direct interaction can be easily mixed and doesn't require a switch of the mode anymore. Signed-off-by: Tobias Anker <tobias.anker@kitsunemimi.moe>
The cluster-mode, which was an original idea of the old backend c++ implmentation, was removed again. While implementing the train and request endpoint for direct interation, i found out, that the new workflow of the cluster provides more oportunities. So in the new version the direct-input can be mixed with the task-input without any conflicts. Signed-off-by: Tobias Anker <tobias.anker@kitsunemimi.moe>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add train- and request-api-endpoint
Related Issues
How it was tested?