feat: support selective yaml service resource deletion - #4729
Merged
leozhang2018 merged 6 commits intoJul 24, 2026
Merged
Conversation
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
huanghongbo-hhb
marked this pull request as ready for review
May 29, 2026 08:47
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
huanghongbo-hhb
force-pushed
the
feat/yaml-service-delete-selected-resources
branch
from
July 21, 2026 07:01
7191949 to
dd05a05
Compare
huanghongbo-hhb
requested review from
Cynthia-0203 and
PetrusZ
and removed request for
PetrusZ
July 21, 2026 08:19
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
huanghongbo-hhb
force-pushed
the
feat/yaml-service-delete-selected-resources
branch
from
July 23, 2026 08:17
1158cf0 to
46f1c50
Compare
Cynthia-0203
approved these changes
Jul 23, 2026
PetrusZ
reviewed
Jul 24, 2026
… to GVKN The intra-service dependency graph (collectK8sServiceResourceDependencies and helpers) was only serialized into the list response and never consumed by the backend, and it does not implement the cross-service ownership check required by product. Cross-service conflicts are already handled by CheckResourceAppliedByOtherEnv, which matches Zadig-managed resources, allows unmanaged ones, and skips the same service on redeploy. Remove the dependency graph, the Dependencies API field, and the redundant apiVersion/kind/name key helper, and match selected resources against the manifest using the existing GVKN convention. Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
PetrusZ
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Main Changes
delete_resourcesgrouped by service namedelete_resourcesis not providedRisk / Compatibility
delete_resourcesis omittedTest
go test ./pkg/microservice/aslan/core/environment/handler ./pkg/microservice/aslan/core/environment/service -run '^$' -count=0Contact
This change is