fix:enhance write method to handle incomplete UTF-8 sequences.#4732
Open
leozhang2018 wants to merge 1 commit into
Open
fix:enhance write method to handle incomplete UTF-8 sequences.#4732leozhang2018 wants to merge 1 commit into
leozhang2018 wants to merge 1 commit into
Conversation
Signed-off-by: leozhang2018 <leozhang2018@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
fix: enhance pod exec terminal output handling to preserve incomplete UTF-8 sequences across writes.
Container output may be split at arbitrary byte boundaries. When a multi-byte UTF-8 character, such as Chinese input echo, was split across
Write()calls, the previous implementation could JSON-encode an incomplete sequence and corrupt the terminal output. This PR buffers incomplete UTF-8 tails and sends them only after the full character is available.Does this PR introduce a user-facing change?
This change is