Fix proxy permission leak and redact sensitive error descriptions#4748
Open
huanghongbo-hhb wants to merge 12 commits into
Open
Fix proxy permission leak and redact sensitive error descriptions#4748huanghongbo-hhb wants to merge 12 commits into
huanghongbo-hhb wants to merge 12 commits into
Conversation
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
PetrusZ
reviewed
Jun 8, 2026
| } | ||
|
|
||
| // TODO: Authroization leaks | ||
| // authorization checks |
Contributor
There was a problem hiding this comment.
不要改这里，可能会有问题，造成普通用户无法使用代理，真的要改的话也要跟前端确认没问题后再改
| nacosConfigs, err := commonservice.ListNacosConfig(j.jobSpec.NacosID, j.jobSpec.NamespaceID, j.jobSpec.GroupName, log.SugaredLogger()) | ||
| if err != nil { | ||
| return fmt.Errorf("fail to list nacos config: %w", err) | ||
| return err |
| return e.cause | ||
| } | ||
|
|
||
| func humanizeNacosError(operation, serverAddr string, err error) error { |
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
Signed-off-by: huanghongbo-hhb <huanghongbo@koderover.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Risk / Compatibility
Test
proxyManagenow returns 403, and Nacos/PingCode validation errors redact credentialsContact
This change is