Skip to content

fix: skip blue-green release cleanup while waiting for manual execution#4750

Open
Cynthia-0203 wants to merge 3 commits into
koderover:mainfrom
Cynthia-0203:fix/blue-green-release-type
Open

fix: skip blue-green release cleanup while waiting for manual execution#4750
Cynthia-0203 wants to merge 3 commits into
koderover:mainfrom
Cynthia-0203:fix/blue-green-release-type

Conversation

@Cynthia-0203

@Cynthia-0203 Cynthia-0203 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What this PR does / Why we need it:

Fixes an issue where blue-green intermediate resources were cleaned up too early when the workflow paused before manually executing the blue-green release job.

After the blue-green deploy job finishes, service details should still show the blue-green release state, including zadigx_release_type="blue-green", while waiting for manual execution of the release job. Previously, entering the manual execution waiting state could trigger cleanup for the blue-green release job before it had actually run, causing the blue deployment/service to be removed.

What is changed and how it works?

This PR updates BlueGreenReleaseV2JobCtl.Clean to skip cleanup when:

the blue-green release job has not started yet
the workflow task is currently paused for manual execution
This keeps the blue-green intermediate resources available during the manual waiting stage. Once the release job actually runs, or the workflow is no longer in the manual pause state, the existing cleanup behavior is preserved.

Does this PR introduce a user-facing change?

  • API change
  • database schema change
  • upgrade assistant change
  • change in non-functional attributes such as efficiency or availability
  • fix of a previous issue

This change is Reviewable

Signed-off-by: Cynthia <chenchen@koderover.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant