fix: skip blue-green release cleanup while waiting for manual execution#4750
Open
Cynthia-0203 wants to merge 3 commits into
Open
fix: skip blue-green release cleanup while waiting for manual execution#4750Cynthia-0203 wants to merge 3 commits into
Cynthia-0203 wants to merge 3 commits into
Conversation
Signed-off-by: Cynthia <chenchen@koderover.com>
Signed-off-by: Cynthia <chenchen@koderover.com>
Signed-off-by: Cynthia <chenchen@koderover.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Fixes an issue where blue-green intermediate resources were cleaned up too early when the workflow paused before manually executing the blue-green release job.
After the blue-green deploy job finishes, service details should still show the blue-green release state, including zadigx_release_type="blue-green", while waiting for manual execution of the release job. Previously, entering the manual execution waiting state could trigger cleanup for the blue-green release job before it had actually run, causing the blue deployment/service to be removed.
What is changed and how it works?
This PR updates BlueGreenReleaseV2JobCtl.Clean to skip cleanup when:
the blue-green release job has not started yet
the workflow task is currently paused for manual execution
This keeps the blue-green intermediate resources available during the manual waiting stage. Once the release job actually runs, or the workflow is no longer in the manual pause state, the existing cleanup behavior is preserved.
Does this PR introduce a user-facing change?
This change is