fix(REN-7): expand #RGB shorthand to #RRGGBB in hex-color decoders #235
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| // | ||
| // MTColorDecoderTest.m | ||
| // iosMath | ||
| // | ||
| // Tests for UIColor(HexString) / NSColor(HexString) colorFromHexString:. | ||
| // REN-7: 3-digit CSS shorthand #RGB should expand to #RRGGBB before decoding. | ||
| // | ||
|
|
||
| @import XCTest; | ||
|
|
||
| #if TARGET_OS_IPHONE | ||
| #import "UIColor+HexString.h" | ||
| #define MTTestColor UIColor | ||
| #else | ||
| #import "NSColor+HexString.h" | ||
| #define MTTestColor NSColor | ||
| #endif | ||
|
|
||
| @interface MTColorDecoderTest : XCTestCase | ||
| @end | ||
|
|
||
| @implementation MTColorDecoderTest | ||
|
|
||
| // Helper: extract red/green/blue components in the 0–255 integer range. | ||
| - (void)assertColor:(MTTestColor *)color red:(int)expectedR green:(int)expectedG blue:(int)expectedB msg:(NSString *)msg { | ||
| XCTAssertNotNil(color, @"%@", msg); | ||
| CGFloat r = 0, g = 0, b = 0, a = 0; | ||
| #if TARGET_OS_IPHONE | ||
| [color getRed:&r green:&g blue:&b alpha:&a]; | ||
| #else | ||
| // NSColor is created with colorWithSRGBRed:; retrieve components in sRGB. | ||
| MTTestColor *srgb = [color colorUsingColorSpace:[NSColorSpace sRGBColorSpace]]; | ||
| [srgb getRed:&r green:&g blue:&b alpha:&a]; | ||
| #endif | ||
| XCTAssertEqual((int)round(r * 255), expectedR, @"red — %@", msg); | ||
| XCTAssertEqual((int)round(g * 255), expectedG, @"green — %@", msg); | ||
| XCTAssertEqual((int)round(b * 255), expectedB, @"blue — %@", msg); | ||
| } | ||
|
|
||
| // REN-7 regression: #f00 must decode to pure red, not near-black green. | ||
| - (void)testThreeDigit_red { | ||
| MTTestColor *color = [MTTestColor colorFromHexString:@"#f00"]; | ||
| [self assertColor:color red:255 green:0 blue:0 msg:@"#f00 should be pure red"]; | ||
| } | ||
|
|
||
| // Additional 3-digit forms. | ||
| - (void)testThreeDigit_green { | ||
| MTTestColor *color = [MTTestColor colorFromHexString:@"#0f0"]; | ||
| [self assertColor:color red:0 green:255 blue:0 msg:@"#0f0 should be pure green"]; | ||
| } | ||
|
|
||
| - (void)testThreeDigit_blue { | ||
| MTTestColor *color = [MTTestColor colorFromHexString:@"#00f"]; | ||
| [self assertColor:color red:0 green:0 blue:255 msg:@"#00f should be pure blue"]; | ||
| } | ||
|
|
||
| - (void)testThreeDigit_white { | ||
| MTTestColor *color = [MTTestColor colorFromHexString:@"#fff"]; | ||
| [self assertColor:color red:255 green:255 blue:255 msg:@"#fff should be white"]; | ||
| } | ||
|
|
||
| - (void)testThreeDigit_black { | ||
| MTTestColor *color = [MTTestColor colorFromHexString:@"#000"]; | ||
| [self assertColor:color red:0 green:0 blue:0 msg:@"#000 should be black"]; | ||
| } | ||
|
|
||
| // 6-digit paths must be unaffected (no regression). | ||
| - (void)testSixDigit_red { | ||
| MTTestColor *color = [MTTestColor colorFromHexString:@"#ff0000"]; | ||
| [self assertColor:color red:255 green:0 blue:0 msg:@"#ff0000 should be pure red"]; | ||
| } | ||
|
|
||
| - (void)testSixDigit_green { | ||
| MTTestColor *color = [MTTestColor colorFromHexString:@"#00ff00"]; | ||
| [self assertColor:color red:0 green:255 blue:0 msg:@"#00ff00 should be pure green"]; | ||
| } | ||
|
|
||
| - (void)testSixDigit_blue { | ||
| MTTestColor *color = [MTTestColor colorFromHexString:@"#0000ff"]; | ||
| [self assertColor:color red:0 green:0 blue:255 msg:@"#0000ff should be pure blue"]; | ||
| } | ||
|
|
||
| - (void)testSixDigit_arbitrary { | ||
| // #4a9 shorthand → #44aa99; full form #44aa99 should match. | ||
| MTTestColor *color = [MTTestColor colorFromHexString:@"#44aa99"]; | ||
| [self assertColor:color red:0x44 green:0xaa blue:0x99 msg:@"#44aa99 arbitrary 6-digit"]; | ||
| } | ||
|
|
||
| @end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
stringWithFormat:with multiple%Cformat specifiers introduces unnecessary overhead because it requires parsing the format string at runtime. Since we are just duplicating characters to form a 6-character string, we can usestringWithCharacters:length:with a local stack array. This is significantly faster and more memory-efficient.