Add \textcolor as a 2-argument alias of \color#252
Merged
Conversation
\textcolor{color}{content} is standard LaTeX for the two-argument color
form, which is exactly what iosMath's \color already implements. Match
"textcolor" in the same atomForCommand: dispatch branch as "color" so it
shares the identical readColor + buildInternal + MTMathColor parse path.
\color behavior is unchanged (still 2-argument); \colorbox is untouched.
Adds parser tests covering \textcolor valid hex, structural equivalence to
\color, and fail-loud on a named (non-hex) color.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for the \textcolor command as an alias of the \color command in MTMathListBuilder.m, along with comprehensive unit tests to verify its behavior, equivalence to \color, and error handling. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This was referenced Jul 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for the standard LaTeX
\textcolor{color}{content}command, closing #157.iosMath's existing
\coloris already implemented as a two-argument command (\color{#RRGGBB}{content}— colors just the content), which is exactly the semantics of standard LaTeX/xcolor\textcolor. So\textcoloris a true alias of the existing path — no new parsing logic or display type.Change
iosMath/lib/MTMathListBuilder.m— widened theatomForCommand:dispatch from[command isEqualToString:@"color"]to also match@"textcolor", so both share the identicalreadColor+buildInternal:true+MTMathColorpath.\colorboxuntouched.iosMathTests/MTMathListBuilderTest.m— three new tests mirroring the existing\colortests: valid hex →MTMathColor; structural equivalence to\color; malformed named color fails loud withMTParseErrorInvalidCommand.Verification
swift build→ Build complete.swift test --filter MTMathListBuilderTest→ 157 tests, 0 failures. Existing color/colorbox tests unchanged and passing.Scope note
This is the minimal alias only. Aligning
\coloritself to LaTeX's switch semantics (a separate, breaking change) was considered and deliberately deferred — seedocs/reqs/2026-07-03-color-textcolor.md.Closes #157
🤖 Generated with Claude Code