fix(printing): handle FileNotFoundError in edit_file diff display#72
Merged
Conversation
When printing the diff for an edit_file tool result, reading the file from disk could raise FileNotFoundError if the file was deleted between the edit and the display. Wrap the read in a try/except to gracefully handle this case. Assisted-by: mini-agent:deepseek-v4-flash
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request wraps the file reading logic in print_tool_result with a try-except block to handle FileNotFoundError gracefully when displaying tool results. The reviewer suggests catching a broader Exception instead of just FileNotFoundError to handle other potential file access errors (such as permission or decoding issues) and prevent CLI crashes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When displaying the diff for an
edit_filetool result in the session history,Path(path).read_text()would raise aFileNotFoundErrorif the file was deleted between the edit and the display. This wraps the read in a try/except to gracefully handle that case.Type of change
Test
Manually verified that printing a session containing an
edit_filetool result for a now-deleted file no longer crashes.Assisted-by: mini-agent:deepseek-v4-flash