Skip to content

fix: oracle table name truncation 237 #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bornedj wants to merge 2 commits into
base: master
Choose a base branch
from
+29 −2
Open

fix: oracle table name truncation 237 #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39bfe64
fix: adds a ui_trim global var
bornedj Apr 30, 2026
32830d8
test: unit tests for default and setting values
bornedj Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions autoload/db_ui/schemas.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ let s:oracle_args = join(
\ 'SET linesize 4000',
\ 'SET pagesize 4000',
\ 'COLUMN owner FORMAT a20',
\ 'COLUMN table_name FORMAT a25',
\ 'COLUMN column_name FORMAT a25',
\ 'COLUMN table_name FORMAT a' . g:db_ui_trim,
\ 'COLUMN column_name FORMAT a' . g:db_ui_trim,
\ '%s',
\ ],
\ ";\n"
Expand Down
1 change: 1 addition & 0 deletions plugin/db_ui.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ let g:db_ui_bind_param_pattern = get(g: , 'db_ui_bind_param_pattern', ':\w\+')
let g:db_ui_is_oracle_legacy = get(g:, 'db_ui_is_oracle_legacy', 0)
let g:db_ui_drawer_sections = get(g:, 'db_ui_drawer_sections', ['new_query', 'buffers', 'saved_queries', 'schemas'])
let g:db_ui_dbout_list_sort = get(g:, 'db_ui_dbout_list_sort', 'asc')
let g:db_ui_trim = get(g:, 'db_ui_trim', 25)

let s:dbui_icons = get(g:, 'db_ui_icons', {})
let s:expanded_icon = get(s:dbui_icons, 'expanded', '▾')
Expand Down
26 changes: 26 additions & 0 deletions test/test-oracle-trim-option.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
let s:suite = themis#suite('Oracle trim option')
let s:expect = themis#helper('expect')

function! s:suite.before() abort
call SetupTestDbs()
endfunction

function! s:suite.after() abort
call Cleanup()
endfunction

function! s:suite.should_have_default_trim_value() abort
call s:expect(g:db_ui_trim).to_equal(25)
endfunction

function! s:suite.should_use_custom_trim_value() abort
call SetOptionVariable('db_ui_trim', 30)
call s:expect(g:db_ui_trim).to_equal(30)
call UnsetOptionVariable('db_ui_trim')
endfunction

function! s:suite.should_reset_to_default_trim_value() abort
call SetOptionVariable('db_ui_trim', 20)
call UnsetOptionVariable('db_ui_trim')
call s:expect(g:db_ui_trim).to_equal(25)
endfunction