fix(metricscollector): parse fractional UNIX timestamps in JSON logs#2672
Open
immanuwell wants to merge 1 commit into
Open
fix(metricscollector): parse fractional UNIX timestamps in JSON logs#2672immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Katib repo! 🎉 Thanks for opening your first PR! We're excited to have you onboard 🚀 Next steps:
Feel free to ask questions in the comments. Thanks again for contributing! 🙏 |
Signed-off-by: immanuwell <pchpr.00@list.ru>
bb283d8 to
5b31599
Compare
Author
|
@anencore94 @Electronic-Waste @gaocegege please take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
file-metricscollectorsupports JSON logs, but numeric UNIX timestamps with fractions were parsed wrong. The fractional part was treated like raw nanoseconds, so1638422847.28721became2021-12-02T05:27:27.000028721Zinstead of2021-12-02T05:27:27.28721Z.This patch keeps the fractional seconds when building the RFC3339 timestamp. String timestamps and integer UNIX timestamps stay the same. This is a small fix, but it is pretty easy to hit on the JSON log path.
Related to #944
Follow-up to #1765
How to reproduce
go test ./pkg/metricscollector/v1beta1/file-metricscollector -count=1TestCollectObservationLogstored1638422847.28721as2021-12-02T05:27:27.000028721Z2021-12-02T05:27:27.28721ZChecklist: