add skip_checkout to periodics which don't need source code#36825
Open
pohly wants to merge 2 commits intokubernetes:masterfrom
Open
add skip_checkout to periodics which don't need source code#36825pohly wants to merge 2 commits intokubernetes:masterfrom
pohly wants to merge 2 commits intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
requested review from
MadhavJivrajani,
Priyankasaggu11929,
andrewsykim and
brianpursley
k8s-ci-robot
added
sig/architecture
k8s-ci-robot
added
the
sig/scalability
k8s-ci-robot
added
sig/storage
Contributor
Author
|
/hold To give time for reviews. |
k8s-ci-robot
added
the
do-not-merge/hold
0712a63 added extra_refs to all periodics which didn't check out source code because that adds the following labels to the Prow pod: - prow.k8s.io/refs.base_ref - prow.k8s.io/refs.org - prow.k8s.io/refs.repo Those labels are needed by the dashboards at monitoring-gke.prow.k8s.io. However, checking out source code that isn't needed by the job slows them down (~ 1 minute), causes more network traffic, and adds the risk that jobs fail when cloning fails. In addition, we then have two sources for which revision got tested (source code checkout and whatever the job itself wrote), which might not be in sync. Adding `skip_cloning` avoids the overhead and should avoid the problem with two revisions because the branch reference never gets resolved. This commit was created by: - changing the dra job configuration so that only jobs which need k/k checked out have need_kubernetes_repo=true (the previous approach) and then adding the repo anyway with skip_cloning for CI jobs - adding skip_cloning on top of the 0712a63 commit in all places where extra_refs were added - rebasing onto master - resolving conflicts: - 1.32.yaml was removed, 1.36.yaml added => re-generated 1.36.yaml to sync with updated jobs on master - generated.yaml removed in b9bc949 => manually fixed all jobs added in that commit (more than just ci-kubernetes-e2e-gce-cos-k8sbeta-alphafeatures and ci-kubernetes-e2e-gce-cos-k8sbeta-default!) - some concurrent changes in other files Conflicts: - config/jobs/kubernetes/generated/generated.yaml - config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml - config/jobs/kubernetes/sig-release/release-branch-jobs/1.32.yaml - config/jobs/kubernetes/sig-release/release-branch-jobs/1.33.yaml - config/jobs/kubernetes/sig-release/release-branch-jobs/1.34.yaml
`source` and the content of hack/build/setup-go.sh only work with bash. Explicitly asking for bash makes it possible to do `make -C releng prepare-release-branch` also on distros where the default shell is not bash (e.g. Debian).
Contributor
Author
|
/retest |
pohly
force-pushed
the
skip-checkout
branch
2 times, most recently
from
ec94c2d to
86eca5b
Compare
k8s-ci-robot
added
the
lgtm
github-project-automation
Bot
moved this from Triage
to PRs - Needs Approver
in SIG Node CI/Test Board
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, pohly, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0712a63 added extra_refs to all periodics which didn't check out source code because that adds the following labels to the Prow pod:
Those labels are needed by the dashboards at monitoring-gke.prow.k8s.io.
However, checking out source code that isn't needed by the job slows them down (~ 1 minute), causes more network traffic, and adds the risk that jobs fail when cloning fails. In addition, we then have two sources for which revision got tested (source code checkout and whatever the job itself wrote), which might not be in sync.
Adding
skip_checkoutavoids the overhead and should avoid the problem with two revisions because the branch reference never gets resolved.This commit was created by:
k/k checked out have need_kubernetes_repo=true (the previous approach)
and then adding the repo anyway with skip_cloning for CI jobs
extra_refs were added
with updated jobs on master
manually fixed all jobs added in that commit (more than just
ci-kubernetes-e2e-gce-cos-k8sbeta-alphafeatures and ci-kubernetes-e2e-gce-cos-k8sbeta-default!)
Conflicts:
For
make -C releng prepare-release-branchto work I had to fix the default shell./assign @BenTheElder @upodroid