Added the updown-ibmcloud.sh script path to the IBM Cloud presubmit jobs#36872
Added the updown-ibmcloud.sh script path to the IBM Cloud presubmit jobs#36872varshadeshmane92 wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
Hi @varshadeshmane92. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Rajalakshmi-Girish
left a comment
There was a problem hiding this comment.
@varshadeshmane92 recently there were changes to the kubetest2 TF deployer setup commands via kubernetes-sigs/provider-ibmcloud-test-infra#91
With this update, running make install-deployer-tf installs prebuilt binaries from IBM COS. However, the purpose of the pull-provider-ibmcloud-test-infra-kubernetes job is to validate the changes introduced in provider-ibmcloud-test-infra repo.
To ensure this, the job should build the binaries dynamically during execution and then use them for cluster testing.
Could you please update the updown-ibmcloud.sh script accordingly, following the approach in the PR: #36853
Do run a test-pj before requesting review here.
c75c822 to
b2cf13f
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: varshadeshmane92 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
instead of using inline commands.
while making the job definition cleaner and easier to maintain.