Skip to content

Added the updown-ibmcloud.sh script path to the IBM Cloud presubmit jobs#36872

Draft
varshadeshmane92 wants to merge 1 commit intokubernetes:masterfrom
varshadeshmane92:update-presubmit-job
Draft

Added the updown-ibmcloud.sh script path to the IBM Cloud presubmit jobs#36872
varshadeshmane92 wants to merge 1 commit intokubernetes:masterfrom
varshadeshmane92:update-presubmit-job

Conversation

@varshadeshmane92
Copy link
Copy Markdown
Contributor

  • Updated the IBM Cloud presubmit job to call the updown-ibmcloud.sh script
    instead of using inline commands.
  • This change automates the end-to-end (E2E) testing for IBM Cloud PowerVS
    while making the job definition cleaner and easier to maintain.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @varshadeshmane92. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs labels Apr 22, 2026
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2026
Copy link
Copy Markdown
Contributor

@Rajalakshmi-Girish Rajalakshmi-Girish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varshadeshmane92 recently there were changes to the kubetest2 TF deployer setup commands via kubernetes-sigs/provider-ibmcloud-test-infra#91

With this update, running make install-deployer-tf installs prebuilt binaries from IBM COS. However, the purpose of the pull-provider-ibmcloud-test-infra-kubernetes job is to validate the changes introduced in provider-ibmcloud-test-infra repo.

To ensure this, the job should build the binaries dynamically during execution and then use them for cluster testing.

Could you please update the updown-ibmcloud.sh script accordingly, following the approach in the PR: #36853
Do run a test-pj before requesting review here.

@kishen-v

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: varshadeshmane92
Once this PR has been reviewed and has the lgtm label, please ask for approval from rajalakshmi-girish. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varshadeshmane92 varshadeshmane92 marked this pull request as draft April 29, 2026 10:56
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants