Skip to content

ca: add branch-specific presubmit jobs with correct k8s version#36877

Open
yashrajshuklaaa wants to merge 1 commit intokubernetes:masterfrom
yashrajshuklaaa:fix/ca-e2e-k8s-versioning
Open

ca: add branch-specific presubmit jobs with correct k8s version#36877
yashrajshuklaaa wants to merge 1 commit intokubernetes:masterfrom
yashrajshuklaaa:fix/ca-e2e-k8s-versioning

Conversation

@yashrajshuklaaa
Copy link
Copy Markdown

@yashrajshuklaaa yashrajshuklaaa commented Apr 22, 2026

The pull-autoscaling-e2e-gci-gce-ca-test job was using --extract=ci/latest unconditionally, which always boots the newest k8s cluster even when the PR targets a release branch.

Add separate presubmit job entries for each actively supported release branch (1.33, 1.34, 1.35) each using the matching --extract=ci/latest-X.Y. The master job is unchanged.

This follows the same pattern used by sig-release branch jobs.

Fixes: kubernetes/autoscaler#9349

The pull-autoscaling-e2e-gci-gce-ca-test job was using
--extract=ci/latest unconditionally, which always boots the newest
k8s cluster even when the PR targets a release branch.

Add separate presubmit job entries for each actively supported
release branch (1.33, 1.34, 1.35), each using the matching
--extract=ci/latest-X.Y. The master job is unchanged.

This follows the same pattern used by sig-release branch jobs.

Fixes: kubernetes/autoscaler#9349
Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2026
@k8s-ci-robot k8s-ci-robot requested review from omerap12 and towca April 22, 2026 16:41
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @yashrajshuklaaa!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/config Issues or PRs related to code in /config labels Apr 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @yashrajshuklaaa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yashrajshuklaaa
Once this PR has been reviewed and has the lgtm label, please assign kwiesmueller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2026
@omerap12
Copy link
Copy Markdown
Member

/assign @Choraden

@yashrajshuklaaa
Copy link
Copy Markdown
Author

yashrajshuklaaa commented Apr 24, 2026

@Choraden pls review this and let me know that should i try the other approach or this looks good to you

@yashrajshuklaaa yashrajshuklaaa marked this pull request as ready for review April 25, 2026 18:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2026
@adrianmoisey
Copy link
Copy Markdown
Member

Something to note: this needs to be updated every time a new release is made. It may be worth documenting that somewhere

@yashrajshuklaaa
Copy link
Copy Markdown
Author

Heyyy @adrianmoisey
thanks for the review!

@yashrajshuklaaa
Copy link
Copy Markdown
Author

you're absolutely right
to address that i can add a comment block directly above the branch-specific job entries in the config
this way anyone doing the branch cut gets a clear , in-file reminder without needing to hunt through separate docs
or
I can also open a follow-up to add a note in the sig-autoscaling README or OWNERS if that's preferred

@yashrajshuklaaa
Copy link
Copy Markdown
Author

yashrajshuklaaa commented Apr 25, 2026

does the overall approach look good to you or
would you prefer any different approach?
happy to iterate

@adrianmoisey
Copy link
Copy Markdown
Member

I don't work on cluster-autoscaler, so I think it best if a cluster-autoscaler maintainer were to give the approval

@yashrajshuklaaa
Copy link
Copy Markdown
Author

okay @adrianmoisey

@omerap12
Copy link
Copy Markdown
Member

@jackfrancis @towca PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CA: improve k8s versioning in E2E tests

6 participants