ca: add branch-specific presubmit jobs with correct k8s version#36877
ca: add branch-specific presubmit jobs with correct k8s version#36877yashrajshuklaaa wants to merge 1 commit intokubernetes:masterfrom
Conversation
The pull-autoscaling-e2e-gci-gce-ca-test job was using --extract=ci/latest unconditionally, which always boots the newest k8s cluster even when the PR targets a release branch. Add separate presubmit job entries for each actively supported release branch (1.33, 1.34, 1.35), each using the matching --extract=ci/latest-X.Y. The master job is unchanged. This follows the same pattern used by sig-release branch jobs. Fixes: kubernetes/autoscaler#9349 Signed-off-by: Yashraj Shukla <shuklayashraj68@gmail.com>
|
Welcome @yashrajshuklaaa! |
|
Hi @yashrajshuklaaa. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yashrajshuklaaa The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @Choraden |
|
@Choraden pls review this and let me know that should i try the other approach or this looks good to you |
|
Something to note: this needs to be updated every time a new release is made. It may be worth documenting that somewhere |
|
Heyyy @adrianmoisey |
|
you're absolutely right |
|
does the overall approach look good to you or |
|
I don't work on cluster-autoscaler, so I think it best if a cluster-autoscaler maintainer were to give the approval |
|
okay @adrianmoisey |
|
@jackfrancis @towca PTAL |
The pull-autoscaling-e2e-gci-gce-ca-test job was using --extract=ci/latest unconditionally, which always boots the newest k8s cluster even when the PR targets a release branch.
Add separate presubmit job entries for each actively supported release branch (1.33, 1.34, 1.35) each using the matching --extract=ci/latest-X.Y. The master job is unchanged.
This follows the same pattern used by sig-release branch jobs.
Fixes: kubernetes/autoscaler#9349