fix: reduce checkRole-driven component requeues#38
Merged
zijiren233 merged 1 commit intoJun 18, 2026
Conversation
im0x0ing
force-pushed
the
fix-role-checkrole-requeue
branch
from
19ce651 to
92c88b3
Compare
Filter Component Pod watch updates that only change internal role bookkeeping annotations, including apps.kubeblocks.io/last-role-snapshot-version and role.kubeblocks.io/event-handled. Role label, access mode, readiness, deletion, and other meaningful Pod changes still enqueue the owning Component. Allow multi-cluster watches to pass through native controller-runtime watch options so the same Pod update predicate can be applied consistently in both single-cluster and multi-cluster setups. Add focused unit coverage for ignored annotation-only updates and meaningful Pod updates that must still trigger Component reconciliation.
im0x0ing
force-pushed
the
fix-role-checkrole-requeue
branch
from
92c88b3 to
42dcb17
Compare
zijiren233
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter Component Pod watch updates that only change internal role bookkeeping annotations, including apps.kubeblocks.io/last-role-snapshot-version and role.kubeblocks.io/event-handled. Role label, access mode, readiness, deletion, and other meaningful Pod changes still enqueue the owning Component.
Allow multi-cluster watches to pass through native controller-runtime watch options so the same Pod update predicate can be applied consistently in both single-cluster and multi-cluster setups.
Add focused unit coverage for ignored annotation-only updates and meaningful Pod updates that must still trigger Component reconciliation.