Fix PostgreSQL standby password repair requeue#39
Open
im0x0ing wants to merge 1 commit into
Open
Conversation
Read standby passwords only from replica pgpass files and stop falling back to pod environment variables. Exclude the leader pod as a password source so the repair uses replicas as the source of truth when correcting the leader-side standby role password. Treat missing pgpass files and pgpass files without a standby entry as unavailable password sources. Record StandbyPasswordUnavailable without requeueing for those non-transient states, while keeping delayed requeue behavior for real exec/runtime failures. Allow the repair transformer to run while the PostgreSQL component is Running, Updating, or Abnormal, and skip components that have no replica password source. Add focused tests for replica-only password sourcing, unavailable pgpass handling, non-running eligible phases, single-replica skips, and runtime failures that should still requeue.
im0x0ing
force-pushed
the
fix-standby-password-repair-requeue
branch
from
15d8edb to
fc362bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read standby password only from replica pgpass files and stop falling back to PGPASSWORD_STANDBY. This avoids using leader-local or environment-derived credentials as the repair source.
Treat missing pgpass files and pgpass files without a standby entry as an unavailable password source. The repair now records a StandbyPasswordUnavailable condition and stops requeueing for those non-transient states, while still requeueing real exec/runtime failures.
Allow the repair transformer to run while the PostgreSQL component is Running, Updating, or Abnormal, and skip single-replica components that have no replica password source.
Add focused tests for replica-only password sourcing, unavailable pgpass handling, non-running eligible phases, single-replica skips, and runtime failures that should still requeue.