Open
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/utils/filterUtils.js">
<violation number="1" location="src/utils/filterUtils.js:82">
P1: Stateful regex bug: If user provides a regex with the global flag (e.g., `/pattern/g`), the `lastIndex` state persists across `.test()` calls, causing incorrect filtering. Consider stripping the `g` flag in `parseRegexFromFilter` since it's not needed for filter matching, or reset `regex.lastIndex = 0` before each test.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add regex filter support
Summary by cubic
Add regex support to text filters for messages and connections using the /pattern/flags format, with a safe fallback to case-insensitive substring matching. This makes filtering more flexible while preserving existing behavior.
Written for commit ae47261. Summary will update on new commits.