Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the authentication service documentation from a single file into a comprehensive multi-page section and removes synchronous database operations in favor of async-only patterns. The changes improve documentation organization and align the auth service with async-first architectural principles.
- Restructures auth docs into dedicated sections (getting started, API reference, service layer, CLI, examples)
- Removes sync
UserServiceclass and consolidates to async-onlyUserService - Updates all documentation examples to require explicit
databasecomponent specification
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mkdocs.yml | Expands auth documentation navigation from single page to multi-section structure |
| docs/services/auth/* | Creates new dedicated auth documentation sections with comprehensive guides |
| docs/services/auth.md | Removes original single-file auth documentation |
| docs/services/index.md | Updates CLI examples to require explicit database component for auth service |
| docs/index.md | Updates quick start examples to include required database component |
| docs/components/index.md | Updates component examples to show explicit database requirement |
| docs/cli-reference.md | Updates all auth service examples to require explicit database component |
| app/services/auth/user_service.py | Removes sync UserService class, keeps only async UserService |
| tests/services/test_auth_integration.py.j2 | Updates tests to use async UserService instead of separate AsyncUserService |
| tests/api/test_auth_endpoints.py.j2 | Updates API tests to use unified async UserService |
| app/services/auth/auth_service.py | Updates import to use unified UserService class |
| app/components/backend/api/auth/router.py | Updates router to use unified async UserService |
| app/cli/auth.py.j2 | Converts CLI commands to async pattern using asyncio.run() |
| hooks/post_gen_project.py | Adds cleanup of auth CLI file when auth service is not included |
Comments suppressed due to low confidence (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
authdocs, dump sync functions in service code, other random stuff.