Conversation
There was a problem hiding this comment.
Pull request overview
Introduces a declarative “file manifest” mechanism to drive post-generation cleanup based on selected components/services, as a first step (R1) in a plugin-system refactor.
Changes:
- Added
aegis.core.file_manifestwithFileManifest, plus helpers to iterate cleanup paths and apply file/dir removal. - Updated component/service registries to declare
files: FileManifestownership (primary paths) for Pattern A cleanup. - Refactored
cleanup_components()to remove per-spec file/dir blocks in favor of iterating manifests; added contract/sanity tests for the manifest behavior and registry shape.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
aegis/core/file_manifest.py |
New manifest model + cleanup helpers (R1 scope). |
aegis/core/post_gen_tasks.py |
Uses manifests for per-spec cleanup (Pattern A) and keeps option-driven cleanups inline. |
aegis/core/components.py |
Adds files: FileManifest to component specs and populates primary cleanup paths. |
aegis/core/services.py |
Adds files: FileManifest to service specs and populates primary cleanup paths. |
tests/core/test_file_manifest.py |
New tests locking in manifest contract and validating registries declare manifests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.