Skip to content

Plugin Stuff Round 2#650

Merged
lbedner merged 1 commit intomainfrom
plugin-stuff-round2
Apr 29, 2026
Merged

Plugin Stuff Round 2#650
lbedner merged 1 commit intomainfrom
plugin-stuff-round2

Conversation

@lbedner
Copy link
Copy Markdown
Owner

@lbedner lbedner commented Apr 29, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 29, 2026 03:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a unified PluginSpec contract (plugin refactor R2) so services and components share one spec shape, while keeping ServiceSpec/ComponentSpec as back-compat subclasses and adding tests to lock in the new behavior.

Changes:

  • Added aegis.core.plugin_spec.PluginSpec + PluginKind as the unified spec layer.
  • Refactored ServiceSpec/ComponentSpec to subclass PluginSpec and updated component registry field names to the canonical dependency fields.
  • Added contract/regression tests ensuring defaults, alias properties, and registry shape invariants.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/core/test_plugin_spec.py Adds contract tests for PluginSpec defaults, legacy alias properties, and registry invariants.
aegis/core/services.py Refactors ServiceSpec into a PluginSpec subclass with a default kind.
aegis/core/plugin_spec.py Adds the new unified PluginSpec dataclass and PluginKind enum.
aegis/core/file_manifest.py Updates docs to reflect that manifests are now consumed via PluginSpec.
aegis/core/components.py Refactors ComponentSpec into a PluginSpec subclass and updates registry entries to canonical dependency field names.

Comment thread aegis/core/services.py
Comment thread aegis/core/components.py
@lbedner lbedner merged commit fea541a into main Apr 29, 2026
12 checks passed
@lbedner lbedner deleted the plugin-stuff-round2 branch April 29, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants