Conversation
There was a problem hiding this comment.
Pull request overview
Introduces a unified PluginSpec contract (plugin refactor R2) so services and components share one spec shape, while keeping ServiceSpec/ComponentSpec as back-compat subclasses and adding tests to lock in the new behavior.
Changes:
- Added
aegis.core.plugin_spec.PluginSpec+PluginKindas the unified spec layer. - Refactored
ServiceSpec/ComponentSpecto subclassPluginSpecand updated component registry field names to the canonical dependency fields. - Added contract/regression tests ensuring defaults, alias properties, and registry shape invariants.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/core/test_plugin_spec.py | Adds contract tests for PluginSpec defaults, legacy alias properties, and registry invariants. |
| aegis/core/services.py | Refactors ServiceSpec into a PluginSpec subclass with a default kind. |
| aegis/core/plugin_spec.py | Adds the new unified PluginSpec dataclass and PluginKind enum. |
| aegis/core/file_manifest.py | Updates docs to reflect that manifests are now consumed via PluginSpec. |
| aegis/core/components.py | Refactors ComponentSpec into a PluginSpec subclass and updates registry entries to canonical dependency field names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.