Skip to content

Bump MSRV to 1.85.0 and rust edition to 2024 #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tnull wants to merge 16 commits into
base: main
Choose a base branch
from

Remove stale persister edition note

4025ed8
Select commit
Loading
Failed to load commit list.
Open

Bump MSRV to 1.85.0 and rust edition to 2024 #4602

Remove stale persister edition note
4025ed8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2026 in 0s

85.84% (-0.32%) compared to 1d36f7b

View this Pull Request on Codecov

85.84% (-0.32%) compared to 1d36f7b

Details

Codecov Report

❌ Patch coverage is 63.35196% with 656 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.84%. Comparing base (1d36f7b) to head (4025ed8).
⚠️ Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/peer_handler.rs 4.91% 232 Missing ⚠️
lightning/src/ln/channelmanager.rs 65.06% 78 Missing and 2 partials ⚠️
lightning-background-processor/src/lib.rs 47.70% 55 Missing and 2 partials ⚠️
lightning-liquidity/src/manager.rs 5.08% 56 Missing ⚠️
lightning-liquidity/src/lsps0/ser.rs 0.00% 27 Missing ⚠️
lightning-invoice/src/lib.rs 31.03% 20 Missing ⚠️
lightning-liquidity/src/lsps2/service.rs 23.07% 20 Missing ⚠️
lightning-persister/src/utils.rs 21.73% 18 Missing ⚠️
lightning/src/chain/channelmonitor.rs 43.33% 14 Missing and 3 partials ⚠️
lightning-liquidity/src/lsps2/client.rs 0.00% 15 Missing ⚠️
... and 25 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4602      +/-   ##
==========================================
- Coverage   86.16%   85.84%   -0.32%     
==========================================
  Files         156      157       +1     
  Lines      108669   109418     +749     
  Branches   108669   109418     +749     
==========================================
+ Hits        93638    93934     +296     
- Misses      12420    12864     +444     
- Partials     2611     2620       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov