Skip to content

Resolve outbound HTLC fails via MonitorEvents #4604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
valentinewallace wants to merge 41 commits into
base: main
Choose a base branch
from

Persistent monitor events for onchain outbound fails

70665c7
Select commit
Loading
Failed to load commit list.
Draft

Resolve outbound HTLC fails via MonitorEvents #4604

Persistent monitor events for onchain outbound fails
70665c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 7, 2026 in 0s

86.10% (-0.09%) compared to 964a84f

View this Pull Request on Codecov

86.10% (-0.09%) compared to 964a84f

Details

Codecov Report

❌ Patch coverage is 88.12729% with 97 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.10%. Comparing base (964a84f) to head (70665c7).
⚠️ Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/chain/channelmonitor.rs 90.14% 25 Missing and 10 partials ⚠️
lightning/src/ln/channel.rs 75.47% 24 Missing and 2 partials ⚠️
lightning/src/ln/channelmanager.rs 90.51% 24 Missing and 2 partials ⚠️
lightning/src/ln/functional_test_utils.rs 64.00% 9 Missing ⚠️
lightning/src/chain/chainmonitor.rs 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4604      +/-   ##
==========================================
- Coverage   86.18%   86.10%   -0.09%     
==========================================
  Files         156      157       +1     
  Lines      108528   109297     +769     
  Branches   108528   109297     +769     
==========================================
+ Hits        93532    94105     +573     
- Misses      12386    12563     +177     
- Partials     2610     2629      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov