Skip to content

Drop QuiescentError::with_negotiation_failure_reason #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkczyz wants to merge 3 commits into
base: main
Choose a base branch
from
+65 −52

Document script_pubkey-only matching in into_unique_contributions

b2b0d43
Select commit
Loading
Failed to load commit list.
Open

Drop QuiescentError::with_negotiation_failure_reason #4608

Document script_pubkey-only matching in into_unique_contributions
b2b0d43
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 8, 2026 in 0s

86.12% (-0.01%) compared to 75ac90a

View this Pull Request on Codecov

86.12% (-0.01%) compared to 75ac90a

Details

Codecov Report

❌ Patch coverage is 66.66667% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.12%. Comparing base (75ac90a) to head (b2b0d43).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 66.66% 10 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4608      +/-   ##
==========================================
- Coverage   86.12%   86.12%   -0.01%     
==========================================
  Files         157      157              
  Lines      108824   108822       -2     
  Branches   108824   108822       -2     
==========================================
- Hits        93727    93719       -8     
- Misses      12480    12486       +6     
  Partials     2617     2617

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov