ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Set Ansible fact injection flags in CI workflows to align test runs with Ansible 2.20 defaults and deprecations.

CI:

• Configure ANSIBLE_INJECT_FACT_VARS=false in qemu-kvm integration tests workflow.
• Propagate an SR_ANSIBLE_INJECT_FACT_VARS flag through the TFT workflow environment for Terraform-based tests.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Configure CI and tft tests to run Ansible with fact variables injection disabled so that new playbook changes conform to Ansible 2.20+ requirements and expose deprecated fact-variable usage early.

Sequence diagram for CI run with SR_ANSIBLE_INJECT_FACT_VARS disabled

sequenceDiagram
  actor Dev
  participant GitHub as GitHub_Repo
  participant GA as GitHub_Actions
  participant TFT as TFT_Workflow_Job
  participant Env as CI_Environment
  participant TS as TFT_Test_Scripts
  participant AN as Ansible

  Dev->>GitHub: Push commit / open PR
  GitHub->>GA: Trigger CI workflows
  GA->>TFT: Start tft.yml job

  TFT->>Env: Export SR_LSR_USER
  TFT->>Env: Export SR_ARTIFACTS_DIR
  TFT->>Env: Export SR_TEST_LOCAL_CHANGES
  TFT->>Env: Export SR_ARTIFACTS_URL
  TFT->>Env: Export SR_ANSIBLE_INJECT_FACT_VARS=false

  TFT->>TS: Invoke tests with Env
  TS->>AN: Run playbooks
  AN->>AN: Read SR_ANSIBLE_INJECT_FACT_VARS=false
  AN->>AN: Run with INJECT_FACTS_AS_VARS=false

  AN-->>TS: Test results and deprecation warnings
  TS-->>GA: Job status and logs
  GA-->>Dev: CI status on PR (including Ansible fact usage warnings)

Loading

File-Level Changes

Change	Details	Files
Ensure GitHub Actions integration tests run with ANSIBLE_INJECT_FACT_VARS disabled.	Set ANSIBLE_INJECT_FACT_VARS environment variable to "false" for the qemu-kvm-integration-tests workflow job so all Ansible invocations in that job run with fact injection disabled.	.github/workflows/qemu-kvm-integration-tests.yml
Propagate Ansible fact injection setting into tft testing via SR_ variable.	Add SR_ANSIBLE_INJECT_FACT_VARS=false to the Terraform (tft) workflow environment so the tft test harness runs with fact injection disabled in downstream jobs or roles.	.github/workflows/tft.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}