ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use the latest tox-lsr and adjust Fedora 43 test environments for newer Ansible versions and faster container tests.

Build:

• Bump tox-lsr from 3.16.0 to 3.17.0 across GitHub Actions workflows for linting, ansible tests, and Python unit tests.

CI:

• Switch Fedora 43 qemu and container integration test scenarios to use Ansible Core 2.20.
• Optimize container test runs in the qemu-kvm integration workflow by controlling requirements installation and callback plugins between test iterations.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43 targets, and adjusts container test environment flags to leverage new tox-lsr behavior for faster, clearer container runs.

Flow diagram for updated ansible-lint GitHub Actions workflow

flowchart TD
  A[ansible_lint_workflow_start] --> B[Checkout_repository]
  B --> C[Setup_Python_environment]
  C --> D[Install_tox_and_tox_lsr_version_3_17_0]
  D --> E[Convert_role_to_collection_format]
  E --> F[Run_ansible_lint_with_tox_lsr_3_17_0]
  F --> G[Workflow_complete]

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr to 3.17.0 across GitHub Actions workflows.	Update tox-lsr version in qemu-kvm integration workflow install step. Update tox-lsr version in ansible-lint workflow install step. Update tox-lsr version in ansible-managed-var-comment workflow install step. Update tox-lsr version in ansible-test workflow install step. Update tox-lsr version in python-unit-test workflow install step.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Use Ansible 2.20 for Fedora 43 qemu and container scenarios.	Change Fedora 43 qemu scenario env to use qemu-ansible-core-2-20. Change Fedora 43 container scenario env to use container-ansible-core-2-20, including bootc variant.	.github/workflows/qemu-kvm-integration-tests.yml
Adjust container integration test loop to align with new tox-lsr container behavior for performance.	Remove LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY overrides from container test step. Introduce SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS flags with false for the first run and true for subsequent runs in the test loop.	.github/workflows/qemu-kvm-integration-tests.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr version string is duplicated across multiple workflows; consider centralizing it via a workflow-level env var or reusable workflow input so future bumps only require a single change.
• In the container test loop, you rely on SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS being false for the first run and then toggled; a short comment explaining why that first non-skipped run is required (e.g. for setup/caching) would help future maintainers understand the ordering constraint.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr version string is duplicated across multiple workflows; consider centralizing it via a workflow-level env var or reusable workflow input so future bumps only require a single change.
- In the container test loop, you rely on SKIP_REQUIREMENTS/SKIP_CALLBACK_PLUGINS being false for the first run and then toggled; a short comment explaining why that first non-skipped run is required (e.g. for setup/caching) would help future maintainers understand the ordering constraint.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}