ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#222
Merged
ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#222
Conversation
…s them [citest_skip] tox-lsr 3.17.1 has a fix for the broken container tests There was one shell function for both setting up the callback plugins and the connection plugin. When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not set, so all subsequent tests failed. The connection plugin must be present and the env. var. must be set in order to run any container tests. The code was fixed to ensure that there is always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS is always set and contains this path. Also, setting up the callback plugins and the connection plugin is already idempotent, so no reason to skip them. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates CI workflows to use tox-lsr 3.17.1 (which fixes broken container tests) and stops skipping callback/connection plugin setup between test runs in the qemu-kvm integration workflow, ensuring container tests always have the required Ansible connection plugin configuration. Sequence diagram for container tests with tox_lsr_3_17_1 connection plugin setupsequenceDiagram
actor Dev as Developer
participant GH as GitHub_Actions_workflow
participant Tox as tox_lsr_3_17_1
participant Ansible as Ansible_test_runner
participant CTests as Container_tests
Dev->>GH: Open_PR_or_push_changes
GH->>GH: Start_qemu_kvm_integration_tests_workflow
GH->>GH: pip_install_tox_lsr_3_17_1
GH->>Tox: Invoke_tox_for_container_tests
Tox->>Tox: Setup_callback_plugins
Tox->>Tox: Setup_connection_plugin
Tox->>Tox: Ensure_ANSIBLE_CONNECTION_PLUGINS_env_set
Tox->>Ansible: Launch_ansible_with_connection_plugin
Ansible->>CTests: Run_container_playbooks_using_connection_plugin
CTests-->>Ansible: Container_tests_pass
Ansible-->>GH: Report_successful_test_run
GH-->>Dev: CI_status_success
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The tox-lsr version is hard-coded in several workflows; consider centralizing this (e.g., via a reusable workflow, composite action, or a shared env variable/step) so future version bumps only need to be made in one place.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tox-lsr version is hard-coded in several workflows; consider centralizing this (e.g., via a reusable workflow, composite action, or a shared env variable/step) so future version bumps only need to be made in one place.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.1 has a fix for the broken container tests
There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.
Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to use tox-lsr 3.17.1 and ensure container test setup steps always run.
Bug Fixes:
CI: