ci: Comply with Ansible partner certification checking [citest_skip]#230
Merged
ci: Comply with Ansible partner certification checking [citest_skip]#230
Conversation
https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md Unfortunately we cannot use the checkers provided by their team because they assume the git repo is in collection format - you cannot convert to collection format first then point the checkers at that collection. Instead, implement our own checkers that do the same (and more) - check with multiple versions of ansible-lint and ansible-test to ensure we cover: * all supported versions of EL * Automation Hub gating * the latest versions of Ansible, including the latest milestone version This requires the latest version of tox-lsr Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideUpdates CI workflows to align with Ansible partner certification requirements by running ansible-lint and ansible-test across specific Ansible/Python version matrices via tox-lsr 3.18.0, replacing direct GitHub Actions integrations and centralizing collection conversion and testing in tox. Flow diagram for updated ansible_lint workflow with version matrixflowchart TD
A["Trigger ansible-lint workflow"] --> B{"Event allowed (no citest_skip)"}
B -- No --> Z["Skip workflow"]
B -- Yes --> C["Set up strategy matrix
versions:
1) ansible-lint 24.* / ansible-core 2.16.* / python 3.12
2) ansible-lint 26.* / ansible-core 2.20.* / python 3.13"]
C --> D["Update pip and git"]
D --> E["Install tox and tox-lsr 3.18.0 via pip3"]
E --> F["Set up Python using actions/setup-python
python-version = matrix.versions.python"]
F --> G["Run tox for collection and ansible-lint-collection
with matrix-specific deps:
LSR_ANSIBLE_LINT_DEP = ansible-lint==matrix.versions.ansible_lint
LSR_ANSIBLE_LINT_ANSIBLE_DEP = ansible-core==matrix.versions.ansible"]
G --> H["Tox env collection converts role to collection format"]
H --> I["Tox env ansible-lint-collection runs ansible-lint against collection"]
I --> J["Report job result for this matrix entry"]
J --> K{"All matrix entries finished"}
K -- No --> C
K -- Yes --> L["Complete ansible-lint workflow"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ansible-collections/partner-certification-checker/blob/main/README.md
Unfortunately we cannot use the checkers provided by their team because they assume
the git repo is in collection format - you cannot convert to collection format first
then point the checkers at that collection. Instead, implement our own checkers that
do the same (and more) - check with multiple versions of ansible-lint and ansible-test
to ensure we cover:
This requires the latest version of tox-lsr
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update CI workflows to align with Ansible partner certification checks by running linting and testing across multiple Ansible and Python versions via tox.
CI: