ci: ansible-lint requires dependencies to be installed [citest_skip]

[richm]

ansible-lint requires the dependencies in meta/collection-requirements.yml
and tests/collection-requirements.yml to be installed. tox-lsr 3.18.1
will ensure they are installed.

Refactor the tests somewhat so that the collection and test steps are separate.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.18.1 and separate collection conversion from lint/test execution.

CI:

• Bump tox-lsr version to 3.18.1 across ansible-related GitHub Actions workflows.
• Split collection conversion into a dedicated tox step before running ansible-lint and ansible-test in CI.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates GitHub Actions workflows to use tox-lsr 3.18.1 and decouples collection conversion from ansible-lint/ansible-test runs so that required collection dependencies are installed via tox-lsr before tests and linting execute.

Sequence diagram for decoupled collection conversion and ansible-lint run

sequenceDiagram
  participant GHA as GitHub_Actions
  participant Job as ansible_lint_job
  participant Pip as pip3
  participant ToxLSR as tox_lsr_3_18_1
  participant ToxCol as tox_env_collection
  participant ToxLint as tox_env_ansible_lint_collection
  participant AnsibleCore as ansible_core
  participant AnsibleLint as ansible_lint

  GHA->>Job: start_matrix_job
  Job->>Pip: install tox_lsr_3_18_1
  Pip-->>Job: tox_lsr_3_18_1_available

  Job->>ToxLSR: tox -e collection
  ToxLSR->>ToxCol: run_collection_env
  ToxCol->>ToxCol: install_collection_dependencies
  ToxCol-->>ToxLSR: collection_ready

  Job->>ToxLSR: tox -e ansible-lint-collection
  ToxLSR->>ToxLint: run_ansible_lint_collection_env
  ToxLint->>AnsibleCore: load_ansible_core_version
  ToxLint->>AnsibleLint: run_ansible_lint_with_collection
  AnsibleLint-->>ToxLint: lint_results
  ToxLint-->>Job: exit_status
  Job-->>GHA: job_status

Loading

File-Level Changes

Change	Details	Files
Upgrade tox-lsr version used in CI workflows to 3.18.1.	Bump tox-lsr installation reference from 3.18.0 to 3.18.1 in all GitHub Actions workflows that install it. Ensure all Python and integration-test workflows consistently pull the same tox-lsr version from the GitHub repository.	.github/workflows/ansible-lint.yml .github/workflows/ansible-test.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/python-unit-test.yml .github/workflows/qemu-kvm-integration-tests.yml
Refactor ansible-lint and ansible-test workflows to run collection conversion separately from test/lint execution.	Add a dedicated step that runs tox -e collection to perform role-to-collection conversion before running ansible-lint or ansible-test. Update ansible-lint and ansible-test steps to only execute their respective tox environments (ansible-lint-collection / ansible-test-) instead of combining them with the collection environment. Align tox invocation with new tox-lsr behavior that manages collection dependency installation via collection requirements files.	.github/workflows/ansible-lint.yml .github/workflows/ansible-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}