Skip to content

ci: Drop explicit "connection:" for provisioning#45

Merged
spetrosi merged 1 commit intolinux-system-roles:mainfrom
martinpitt:tmt-drop-connection
Apr 2, 2025
Merged

ci: Drop explicit "connection:" for provisioning#45
spetrosi merged 1 commit intolinux-system-roles:mainfrom
martinpitt:tmt-drop-connection

Conversation

@martinpitt
Copy link
Copy Markdown
Contributor

This forces having to have a system libvirt instance, but that is incompatible with running tests inside of containers/toolbox. It also seems unnecessary: session libvirt networking and the tests work just fine.

Drop the explicit setting and let tmt/testcloud pick its internal default (which is qemu:///session). This wasn't relevant for running on Testing Farm anyway.

Enhancement: tmt tests can now be run locally out of a container or toolbox.

Reason: Requiring a system libvirtd instance is an unnecessary requirement (e.g. my laptop doesn't have libvirtd installed at all, I run everything in toolbox). tmt defaults to qemu:///session for this reason, which is much more flexible and safer, and less demanding.

Result:

Issue Tracker Tickets (Jira or BZ if any): -

tmt run --until report provision --how virtual --image fedora-42 succeeds for me now. It previously failed with

libvirt: XML-RPC error : Failed to connect socket to '/var/run/libvirt/virtqemud-sock': No such file or directory

Being able to run tmt locally is quite important for me, especially as tmt tests don't run by default in PRs -- they need to be explicitly requested by project maintainers. I am not one, and it's actually useful to be in that state for a while to ensure that the experience for external contributors is good enough.

This forces having to have a system libvirt instance, but that is
incompatible with running tests inside of containers/toolbox. It also
seems unnecessary: session libvirt networking and the tests work just
fine.

Drop the explicit setting and let tmt/testcloud pick its internal
default (which is `qemu:///session`). This wasn't relevant for running
on Testing Farm anyway.

Signed-off-by: Martin Pitt <mpitt@redhat.com>
@spetrosi
Copy link
Copy Markdown
Contributor

spetrosi commented Apr 1, 2025

lgtm, we need to remove this from https://github.com/linux-system-roles/.github/blob/main/playbooks/templates/plans/test_playbooks_parallel.fmf - automation builds this file from there

@spetrosi
Copy link
Copy Markdown
Contributor

spetrosi commented Apr 1, 2025

[citest]

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3f6b3ec). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage        ?   52.31%           
=======================================
  Files           ?        1           
  Lines           ?      346           
  Branches        ?        0           
=======================================
  Hits            ?      181           
  Misses          ?      165           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martinpitt
Copy link
Copy Markdown
Contributor Author

Thanks @spetrosi for the pointer! I'll submit a PR there, but good to see a full test run here. Just for avoidance of doubt, these are the workflow and also the tmt tests, right? I see they aren't triggered via packit, but via a custom workflow (note: you can trigger packit tests manually as well).

@martinpitt
Copy link
Copy Markdown
Contributor Author

Sent to linux-system-roles/.github#91

@martinpitt martinpitt closed this Apr 1, 2025
@martinpitt martinpitt deleted the tmt-drop-connection branch April 1, 2025 17:10
@martinpitt martinpitt restored the tmt-drop-connection branch April 2, 2025 13:36
@martinpitt martinpitt reopened this Apr 2, 2025
@martinpitt
Copy link
Copy Markdown
Contributor Author

Reopening as per @spetrosi 's suggestion in Chat. Sorry for the misunderstanding, I thought the PR would only go to the .github repo.

@spetrosi spetrosi merged commit 3ffcc73 into linux-system-roles:main Apr 2, 2025
27 checks passed
@martinpitt martinpitt deleted the tmt-drop-connection branch April 2, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants