ci: Drop explicit "connection:" for provisioning#45
ci: Drop explicit "connection:" for provisioning#45spetrosi merged 1 commit intolinux-system-roles:mainfrom
Conversation
This forces having to have a system libvirt instance, but that is incompatible with running tests inside of containers/toolbox. It also seems unnecessary: session libvirt networking and the tests work just fine. Drop the explicit setting and let tmt/testcloud pick its internal default (which is `qemu:///session`). This wasn't relevant for running on Testing Farm anyway. Signed-off-by: Martin Pitt <mpitt@redhat.com>
|
lgtm, we need to remove this from https://github.com/linux-system-roles/.github/blob/main/playbooks/templates/plans/test_playbooks_parallel.fmf - automation builds this file from there |
|
[citest] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage ? 52.31%
=======================================
Files ? 1
Lines ? 346
Branches ? 0
=======================================
Hits ? 181
Misses ? 165
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @spetrosi for the pointer! I'll submit a PR there, but good to see a full test run here. Just for avoidance of doubt, these are the workflow and also the tmt tests, right? I see they aren't triggered via packit, but via a custom workflow (note: you can trigger packit tests manually as well). |
|
Sent to linux-system-roles/.github#91 |
|
Reopening as per @spetrosi 's suggestion in Chat. Sorry for the misunderstanding, I thought the PR would only go to the .github repo. |
This forces having to have a system libvirt instance, but that is incompatible with running tests inside of containers/toolbox. It also seems unnecessary: session libvirt networking and the tests work just fine.
Drop the explicit setting and let tmt/testcloud pick its internal default (which is
qemu:///session). This wasn't relevant for running on Testing Farm anyway.Enhancement: tmt tests can now be run locally out of a container or toolbox.
Reason: Requiring a system libvirtd instance is an unnecessary requirement (e.g. my laptop doesn't have libvirtd installed at all, I run everything in toolbox).
tmtdefaults toqemu:///sessionfor this reason, which is much more flexible and safer, and less demanding.Result:
Issue Tracker Tickets (Jira or BZ if any): -
tmt run --until report provision --how virtual --image fedora-42succeeds for me now. It previously failed withBeing able to run
tmtlocally is quite important for me, especially as tmt tests don't run by default in PRs -- they need to be explicitly requested by project maintainers. I am not one, and it's actually useful to be in that state for a while to ensure that the experience for external contributors is good enough.