fix(litestar DTO): Ensure ORM descriptor fields are not evaluated during DTO creation#664
Merged
provinzkraut merged 1 commit intomainfrom Feb 1, 2026
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
==========================================
+ Coverage 79.06% 79.08% +0.01%
==========================================
Files 99 99
Lines 7915 7922 +7
Branches 1073 1073
==========================================
+ Hits 6258 6265 +7
- Misses 1315 1316 +1
+ Partials 342 341 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cofin
approved these changes
Feb 1, 2026
Member
cofin
left a comment
There was a problem hiding this comment.
LGTM - much more elegant than what I tried to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix #646.
When processing property fields on SQLAlchemy models for the Litestar DTO, there was sometimes unexpected behaviour caused by the inspecting code evaluating the ORM descriptors such as
hybrid_property.Fix this behaviour by skipping all known ORM fields (as reported by the ORM), and not using
inspect.getmembers.