Skip to content

fix(core): make default user span time explicit #5699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenghao-mou merged 2 commits into from
May 11, 2026
+4 −2
Merged

fix(core): make default user span time explicit #5699

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2463a2d
fix(core): make default user span time explicit
chenghao-mou May 10, 2026
6e2ebc4
fix type issues
chenghao-mou May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions livekit-agents/livekit/agents/voice/audio_recognition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,10 +1267,11 @@ def _ensure_user_turn_span(self, start_time: float | None = None) -> trace.Span:
if self._user_turn_span and self._user_turn_span.is_recording():
return self._user_turn_span

start_time_ns = int(start_time * 1_000_000_000) if start_time else None
start_time: float = start_time or time.time()
start_time_ns = int(start_time * 1_000_000_000)
self._user_turn_span = tracer.start_span("user_turn", start_time=start_time_ns)

if start_time is not None and self._user_turn_start is None:
if self._user_turn_start is None:
self._user_turn_start = start_time

if (room_io := self._session._room_io) and room_io.linked_participant:
Expand Down
Loading