Skip to content

fix: autogen ci#374

Merged
lorenzodonini merged 1 commit intolorenzodonini:masterfrom
xBlaz3kx:fix/autogen
Aug 17, 2025
Merged

fix: autogen ci#374
lorenzodonini merged 1 commit intolorenzodonini:masterfrom
xBlaz3kx:fix/autogen

Conversation

@xBlaz3kx
Copy link
Copy Markdown
Contributor

@xBlaz3kx xBlaz3kx commented Jul 25, 2025

Proposed changes

  • Fixed autogen workflow to check out correct repository on pull request (should be fork instead of current repository)

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@xBlaz3kx xBlaz3kx requested a review from lorenzodonini as a code owner July 25, 2025 17:45
@lorenzodonini
Copy link
Copy Markdown
Owner

I approved this because no harm, but please have a look at my suggested changes here. That's how I initially envisioned auto-generated mocks and it's also the setup I use in many other projects.

@xBlaz3kx
Copy link
Copy Markdown
Contributor Author

Thanks! The changes Ive made will be more friendly for generating mocks in PRs, since I see every PR has autogen mock step failing because it checks out the wrong repository. Can we merge this?

@lorenzodonini lorenzodonini merged commit b22429c into lorenzodonini:master Aug 17, 2025
5 checks passed
@lorenzodonini
Copy link
Copy Markdown
Owner

Thanks! The changes Ive made will be more friendly for generating mocks in PRs, since I see every PR has autogen mock step failing because it checks out the wrong repository. Can we merge this?

Merged, but if you agree with my changes in #377, then these changes would no longer be necessary.

@xBlaz3kx xBlaz3kx deleted the fix/autogen branch August 17, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants