Skip to content

Fix error counter keying on dynamic error messages #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwormald wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix error counter keying on dynamic error messages #182

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
846e7fd
Fix error counter keying on dynamic error messages
andrewwormald Mar 10, 2026
08af657
Add tests for label-based error counter keying
andrewwormald Mar 10, 2026
33333bc
Require at least one label in ErrorCounter API
andrewwormald Mar 10, 2026
01c6cd0
Remove unused err parameter from ErrorCounter interface
andrewwormald Mar 29, 2026
cfce9c0
Use null byte separator in makeKey to prevent key collisions
andrewwormald May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions internal/errorcounter/errorcounter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,30 @@ func (c *Counter) Add(err error, labels ...string) int {
c.mu.Lock()
defer c.mu.Unlock()

errMsg := err.Error()
errMsg += strings.Join(labels, "-")
c.store[errMsg] += 1
return c.store[errMsg]
key := makeKey(labels)
c.store[key] += 1
return c.store[key]
}

func (c *Counter) Count(err error, labels ...string) int {
c.mu.Lock()
defer c.mu.Unlock()

errMsg := err.Error()
errMsg += strings.Join(labels, "-")
return c.store[errMsg]
key := makeKey(labels)
return c.store[key]
}

func (c *Counter) Clear(err error, labels ...string) {
c.mu.Lock()
defer c.mu.Unlock()

errMsg := err.Error()
errMsg += strings.Join(labels, "-")
c.store[errMsg] = 0
return
key := makeKey(labels)
delete(c.store, key)
}

// makeKey builds a stable key from labels only. The error message is excluded
// because it often contains dynamic data (timestamps, IDs) which would create
// unique keys and prevent the PauseAfterErrCount threshold from ever being reached.
func makeKey(labels []string) string {
return strings.Join(labels, "-")
}
Loading