Skip to content

fix(stickies): restore full state on failed delete #9064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidIMk wants to merge 2 commits into
base: preview
Choose a base branch
from
Open

fix(stickies): restore full state on failed delete #9064

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81662df
fix(stickies): restore full state on failed delete
DavidIMk May 13, 2026
082dd65
fix(stickies): add guard
DavidIMk May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/web/core/services/sticky.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class StickyService extends APIService {
}

async getSticky(workspaceSlug: string, id: string) {
return this.get(`/api/workspaces/${workspaceSlug}/stickies/${id}`)
return this.get(`/api/workspaces/${workspaceSlug}/stickies/${id}/`)
.then((res) => res?.data)
.catch((err) => {
throw err?.response?.data;
Expand All @@ -59,7 +59,7 @@ export class StickyService extends APIService {
}

async deleteSticky(workspaceSlug: string, id: string) {
return await this.delete(`/api/workspaces/${workspaceSlug}/stickies/${id}`)
return await this.delete(`/api/workspaces/${workspaceSlug}/stickies/${id}/`)
.then((res) => res?.data)
.catch((err) => {
throw err?.response?.data;
Expand Down
12 changes: 9 additions & 3 deletions apps/web/core/store/sticky/sticky.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,16 @@ export class StickyStore implements IStickyStore {
} catch (error) {
console.error("Error in updating sticky:", error);
this.stickies[id] = sticky;
throw new Error();
throw error;
}
};

deleteSticky = async (workspaceSlug: string, id: string) => {
const sticky = this.stickies[id];
if (!sticky) return;
const previousWorkspaceStickies = [...(this.workspaceStickies[workspaceSlug] || [])];
const previousActiveStickyId = this.activeStickyId;
const previousRecentStickyId = this.recentStickyId;
try {
this.workspaceStickies[workspaceSlug] = this.workspaceStickies[workspaceSlug].filter(
(stickyId) => stickyId !== id
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
Expand All @@ -220,9 +223,12 @@ export class StickyStore implements IStickyStore {
delete this.stickies[id];
this.recentStickyId = this.workspaceStickies[workspaceSlug][0];
await this.stickyService.deleteSticky(workspaceSlug, id);
} catch (e) {
console.log(e);
} catch (error) {
this.stickies[id] = sticky;
this.workspaceStickies[workspaceSlug] = previousWorkspaceStickies;
this.activeStickyId = previousActiveStickyId;
this.recentStickyId = previousRecentStickyId;
throw error;
}
};

Expand Down