Skip to content

fix: support /god-mode route without trailing slash (#9068) #9070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rishipandey2 wants to merge 3 commits into
base: preview
Choose a base branch
from
+41 −7
Open

fix: support /god-mode route without trailing slash (#9068) #9070

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8388e8c
C:/Program Files/Git/god-mode without trailing slash renders a blank/…
rishipandey2 May 14, 2026
5a40abf
Fix: Add normalizeBasePath utility and update imports
rishipandey2 May 14, 2026
3de5608
docs: add JSDoc for normalizeBasePath
rishipandey2 May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/admin/react-router.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { Config } from "@react-router/dev/config";
import { joinUrlPath } from "@plane/utils";

const basePath = joinUrlPath(process.env.VITE_ADMIN_BASE_PATH ?? "", "/") ?? "/";
const rawBasePath = process.env.VITE_ADMIN_BASE_PATH ?? "";

const basePath = rawBasePath === "/" || rawBasePath === "" ? "/" : rawBasePath.replace(/\/+$/, "");

export default {
appDirectory: "app",
Expand Down
5 changes: 3 additions & 2 deletions apps/admin/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import * as dotenv from "dotenv";
import { reactRouter } from "@react-router/dev/vite";
import { defineConfig } from "vite";
import tsconfigPaths from "vite-tsconfig-paths";
import { joinUrlPath } from "@plane/utils";

dotenv.config({ path: path.resolve(__dirname, ".env") });

Expand All @@ -15,7 +14,9 @@ const viteEnv = Object.keys(process.env)
return a;
}, {});

const basePath = joinUrlPath(process.env.VITE_ADMIN_BASE_PATH ?? "", "/") ?? "/";
const rawBasePath = process.env.VITE_ADMIN_BASE_PATH ?? "";

const basePath = rawBasePath === "/" || rawBasePath === "" ? "/" : rawBasePath.replace(/\/+$/, "");

export default defineConfig(() => ({
base: basePath,
Expand Down