Skip to content

fix: normalize OAuth provider config flags #9135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KanteshMurade wants to merge 1 commit into
base: preview
Choose a base branch
from
+8 −4
Open

fix: normalize OAuth provider config flags #9135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions apps/api/plane/license/api/views/instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@
from django.views.decorators.cache import cache_control


def _is_config_enabled(value):
return str(value).strip().lower() in ("1", "true")


class InstanceEndpoint(BaseAPIView):
def get_permissions(self):
if self.request.method == "PATCH":
Expand Down Expand Up @@ -129,10 +133,10 @@ def get(self, request):
# Authentication
data["enable_signup"] = ENABLE_SIGNUP == "1"
data["is_workspace_creation_disabled"] = DISABLE_WORKSPACE_CREATION == "1"
data["is_google_enabled"] = IS_GOOGLE_ENABLED == "1"
data["is_github_enabled"] = IS_GITHUB_ENABLED == "1"
data["is_gitlab_enabled"] = IS_GITLAB_ENABLED == "1"
data["is_gitea_enabled"] = IS_GITEA_ENABLED == "1"
data["is_google_enabled"] = _is_config_enabled(IS_GOOGLE_ENABLED)
data["is_github_enabled"] = _is_config_enabled(IS_GITHUB_ENABLED)
data["is_gitlab_enabled"] = _is_config_enabled(IS_GITLAB_ENABLED)
data["is_gitea_enabled"] = _is_config_enabled(IS_GITEA_ENABLED)
data["is_magic_login_enabled"] = ENABLE_MAGIC_LINK_LOGIN == "1"
data["is_email_password_enabled"] = ENABLE_EMAIL_PASSWORD == "1"

Expand Down
Loading