Bug fixes and small enhancements#21
Conversation
|
I've also removed the unused |
|
I've also included a bug fix for the external spool not persisting the selected spool as discussed in #20 |
The barcode endpoint is being used. Maybe not in your changes, but I scanned the barcode with the camera button and than it selected the spool I scanned. Can you alter your change to only add functionality for now? |
My changes do not require users to print QR codes every time. The end user functionality of using barcodes is still intact. I've just also added the ability to use Spoolman QR codes in addition to barcodes. The change I made was purely on the backend and a simplification of existing logic. We already get the barcode field from spoolman when calling GET /spools, so the /Spools/barcode endpoint was unnecessary. I've tested on my version of the code and both barcodes (from the Spoolman extra data field) and Spoolman QR codes work. Therefore, end user functionality was not changed and only added to. |
Summary
This PR adds a settings UI for customization options and fixes the QR code scanning functionality which was not working.
Changes:
#4 Bambu Lab PETG...) so they don't get cut offTesting:
Screenshots:
