pre-commit autoupdate#705
Conversation
1d22a37 to
940fa60
Compare
940fa60 to
0db94ec
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
=======================================
Coverage 60.63% 60.63%
=======================================
Files 69 69
Lines 5327 5327
=======================================
Hits 3230 3230
Misses 2097 2097 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0db94ec to
3ffc579
Compare
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.7 → v0.15.12](astral-sh/ruff-pre-commit@v0.14.7...v0.15.12) - [github.com/pre-commit/mirrors-mypy: v1.19.0 → v1.20.2](pre-commit/mirrors-mypy@v1.19.0...v1.20.2) - [github.com/codespell-project/codespell: v2.4.1 → v2.4.2](codespell-project/codespell@v2.4.1...v2.4.2) - [github.com/MarcoGorelli/cython-lint: v0.18.1 → v0.19.0](MarcoGorelli/cython-lint@v0.18.1...v0.19.0)
3ffc579 to
a50acd6
Compare
shyuep
left a comment
There was a problem hiding this comment.
Automated PR review generated by Claude (Opus 4.7) on behalf of @shyuep. Based purely on the diff and current GitHub Actions state — no code was executed locally.
Routine pre-commit autoupdate (ruff 0.14.7 → 0.15.12, mypy 1.19.0 → 1.20.2, codespell 2.4.1 → 2.4.2, cython-lint 0.18.1 → 0.19.0). The bumps themselves are fine and lint/build are green.
Not auto-merging because CI is red:
test (ubuntu-latest, 3.11)→ 2 failures, bothFileNotFoundError: https://github.com/materialsvirtuallab/matgl/raw/main/pretrained_models/M3GNet-MP-2018.6.1-Eform/model.jsonfollowed byValueError: Bad serialized model or bad model name. These are unrelated to this PR —matglhas moved to thematerialyzeaiorg and the hard-codedmaterialsvirtuallabraw-content URL no longer resolves. Same failure will reproduce onmaster.test (ubuntu-latest, 3.10)was cancelled by the matrix fail-fast.pre-commit.ci - pris failing as well — likely stale; please re-trigger after fixing the model URL.
Suggested fix (separate PR): update the M3GNet model URL / pin in maml's test dependencies (or in matgl itself) to point at the new materialyzeai/matgl location, then this autoupdate can land cleanly. Once that's resolved I'd be happy to merge this PR.
updates: