[freezed] reorder accumulates as allowed by Elpi 3.7#590
Draft
[freezed] reorder accumulates as allowed by Elpi 3.7#590
Conversation
gares
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATM this code works with Elpi 3.7.1 but makes MCA a bit slower. It is unclear why. The main change when the code hits the runtime is that the DB is at the end, rather than at the beginning. I don't think this causes any surprise, but apparently something becomes slower. I did not investigate it further.
If we decide to make this change we cal always accumulate the DB early, and that should give the same performances. To be tested.