Skip to content

Interface + base class structure for callback module#802

Draft
GiovanniCanali wants to merge 4 commits intomathLab:0.3from
GiovanniCanali:callback_refactory
Draft

Interface + base class structure for callback module#802
GiovanniCanali wants to merge 4 commits intomathLab:0.3from
GiovanniCanali:callback_refactory

Conversation

@GiovanniCanali
Copy link
Copy Markdown
Collaborator

Description

This PR fixes #800

In this PR, the following updates for the callback module have been introduced:

  • Renamed NormalizerDataCallback to DataNormalizer to align with PINA conventions.
  • Added deprecation warnings for backward compatibility.
  • Implemented the interface + base class structure for refinement callbacks.
  • Enhanced and extended documentation to improve clarity and usability.
  • Enhanced test suite to improve coverage.

The core logic underpinning the entire callback module has remained unchanged from a user perspective.

Checklist

  • Code follows the project’s Code Style Guidelines
  • Tests have been added or updated
  • Documentation has been updated if necessary
  • Pull request is linked to an open issue

@GiovanniCanali GiovanniCanali requested a review from ndem0 May 5, 2026 15:22
@GiovanniCanali GiovanniCanali self-assigned this May 5, 2026
@GiovanniCanali GiovanniCanali added enhancement New feature or request pr-to-review Label for PR that are ready to been reviewed 0.3 Related to 0.3 release labels May 5, 2026
@GiovanniCanali
Copy link
Copy Markdown
Collaborator Author

Currently on hold, waiting for #801 to be merged.

@GiovanniCanali GiovanniCanali force-pushed the callback_refactory branch 2 times, most recently from 2239315 to c24fc8e Compare May 6, 2026 10:00
@GiovanniCanali GiovanniCanali marked this pull request as ready for review May 7, 2026 10:10
@GiovanniCanali GiovanniCanali requested review from a team and dario-coscia as code owners May 7, 2026 10:10
@GiovanniCanali GiovanniCanali marked this pull request as draft May 8, 2026 09:20
@GiovanniCanali GiovanniCanali added pr-to-fix Label for PR that needs modification and removed pr-to-review Label for PR that are ready to been reviewed labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.3 Related to 0.3 release enhancement New feature or request pr-to-fix Label for PR that needs modification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant